Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identify information to segment overrides and mv #1948

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Add identify information to segment overrides and mv #1948

merged 3 commits into from
Feb 23, 2023

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

Adds information that users need to be identified to use segment overrides / mv.

image
image

@kyle-ssg kyle-ssg linked an issue Feb 23, 2023 that may be closed by this pull request
Add hints that Segments and % splits require Identities! #1924
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

Uffizzi Preview deployment-17178 was deleted.

@matthewelwell
Copy link
Contributor

Should we add this to the 'Features' tab on the Edit Segment modal too for completeness?

image

@kyle-ssg
Copy link
Member Author

Added
image

@matthewelwell matthewelwell merged commit 63ffff6 into main Feb 23, 2023
@matthewelwell matthewelwell deleted the chores/add_identif_information branch February 23, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@dabeeeenster dabeeeenster Awaiting requested review from dabeeeenster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hints that Segments and % splits require Identities!
2 participants
@kyle-ssg @matthewelwell