Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chores/delete rule flag #1931

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Chores/delete rule flag #1931

merged 3 commits into from
Feb 20, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 20, 2023 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

Also includes #1928

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • [] I have filled in the "How did you test this code" section below?

Changes

This will add the delete flag to any level of rules whilst they are being removed.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023 •
edited
Loading

Uffizzi Preview deployment-16703 was deleted.

matthewelwell
matthewelwell approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-ssg I'm going to merge this now and you can add the fix for string / boolean in another PR.

@matthewelwell matthewelwell merged commit 48de621 into main Feb 20, 2023
@matthewelwell matthewelwell deleted the chores/delete_rule_flag branch February 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell