Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archived filter to compare environments #1908

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 7, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

Adds an archived filter to the compare page.

image

How did you test this code?

Used the compare feature in production.

# Conflicts:
#	frontend/web/components/CompareEnvironments.js
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

Uffizzi Preview deployment-16537 was deleted.

@matthewelwell
Copy link
Contributor

@kyle-ssg this doesn't seem to be working too well for me in the Uffizzi preview environment. I've noticed a couple of issues so far:

  1. In a project where there are 2 flags and 2 environments, one archived and one not, when there is a difference between the enabled state of the non-archived flag, I just get a blank screen when I try to compare the 2 environments.
  2. In the same project, if there are no differences between the features in each of the environments, I don't see the archived button.

I'm going to try to verify this in a second project to confirm it happens every time but I wanted to write down the reproduction steps first.

@matthewelwell
Copy link
Contributor

Yep, confirmed that this is reproducible in a fresh project following the exact steps as above.

The compare UI without the archived button (when there aren't any changes):

image

Blank screen (when there are changes):

image

@kyle-ssg
Copy link
Member Author

This looked to be a pre-existing issue attempting to compare to exactly matching environments. Should be fixed @matthewelwell

@kyle-ssg kyle-ssg merged commit 6b98296 into main Feb 23, 2023
@kyle-ssg kyle-ssg deleted the chores/filter_compare_by_archived branch February 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants