Prevent known domains in pipedrive #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
commented
Dec 2, 2022
| @@ -798,3 +798,7 @@ | |||
| PIPEDRIVE_SIGN_UP_TYPE_DEAL_FIELD_KEY = env.str( | |||
| "PIPEDRIVE_SIGN_UP_TYPE_DEAL_FIELD_KEY", None | |||
| ) | |||
| PIPEDRIVE_IGNORE_DOMAINS = env.list( | |||
| "PIPEDRIVE_IGNORE_DOMAINS", | |||
| ["solidstategroup.com", "flagsmith.com", "bullet-train.io"], | |||
There was a problem hiding this comment.
should we add gmail.com, hotmail.com, etc. to this list?
dabeeeenster
approved these changes
Dec 2, 2022
matthewelwell
deleted the
improvement/prevent-known-domains-in-pipedrive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Add a list of known domains so we can prevent leads being added to Pipedrive.
How did you test this code?
Added unit tests