feat(feature-states/segments): Add get_by_uuid, and id #1718
+78
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
changed the title
api/features/tests/test_views.py
Outdated
| base_url = reverse( | ||
| "api-v1:features:get-feature-state-by-uuid", args=[feature_state.uuid] | ||
| ) | ||
| url = f"{base_url}?environment={environment}" |
There was a problem hiding this comment.
If we're getting the feature state by uuid I'm a bit unclear why we need the environment query parameter here?
api/features/views.py
Outdated
| qs = ( | ||
| FeatureState.objects.filter(feature__project__in=accessible_projects) | ||
| .select_related("feature_state_value") | ||
| .prefetch_related("multivariate_feature_state_values") |
There was a problem hiding this comment.
If this is a request for a single object, I don't think the prefetch related actually adds anything does it?
gagantrivedi
force-pushed
the
feat/feature-state/get-by--uuid
branch
from
a8018ea to
9de56d4
Compare
matthewelwell
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Add api to fetch feature_state with uuid
Add api to fetch feture segment with id
How did you test this code?
adds unit test case to cover the change