feat: add segment source metadata enum and bump-engine-test-data #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gagantrivedi
commented
Nov 17, 2025
gagantrivedi
commented
- Add SegmentSource enum with Api and IdentityOverride variants
- Update SegmentMetadata to use typed SegmentSource instead of optional string
- Add snake_case serialization to support test data format
- Update engine-test-data submodule to v3.4.2
- Export SegmentSource in public API
- Add SegmentSource enum with Api and IdentityOverride variants - Update SegmentMetadata to use typed SegmentSource instead of optional string - Add snake_case serialization to support test data format - Update engine-test-data submodule to v3.4.2 - Export SegmentSource in public API
Zaimwa9
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.