feat: Add evaluation context #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
force-pushed
the
feat/engine-eval-ctx
branch
7 times, most recently
from
e9ab450 to
c6b5a56
Compare
gagantrivedi
force-pushed
the
feat/engine-eval-ctx
branch
from
c6b5a56 to
4f0a0fb
Compare
gagantrivedi
changed the title
khvn26
requested changes
Nov 5, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Looks good overall. Left a handful of comments.
- Implement ConditionValue enum to handle string or array values - Supports Single(String) and Multiple(Vec<String>) variants - Custom deserializer handles JSON arrays, JSON array strings, and comma-separated strings - Helper methods: as_string(), as_vec(), contains_string() - Simplify IN operator implementation - Use ConditionValue's contains_string() for string matching - Remove redundant JSON array parsing logic
- Fix collapsible_if warning: collapse nested if statements - Fix manual_strip warning: use strip_suffix instead of manual slicing - Fix unwrap_or_default warning: use or_default() instead of or_insert_with(Vec::new)
- Compare flag reason field in addition to enabled and value - Ensure evaluation reasons (DEFAULT, TARGETING_MATCH, SPLIT) are correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.