Fix/segment priority: Add feature segment #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested changes
May 27, 2022
src/features/mod.rs
Outdated
| pub fn is_higher_segment_priority(&self, other: &FeatureState) -> bool { | ||
| match &other.feature_segment { | ||
| None if self.feature_segment.is_some() => true, | ||
| Some(segment) if self.feature_segment.is_some() => { |
Contributor
There was a problem hiding this comment.
Maybe let's be explicit that this is a feature_segment, not a segment? Some(feature_segment)
src/features/mod.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn feature_state_is_higher_segment_priority_when_both_fs_don_not_have_feature_segment() { |
Contributor
There was a problem hiding this comment.
This has turned into a test for all cases, right? So this name no longer makes sense.
Member
Author
There was a problem hiding this comment.
Ah, yes, good point. I updated it
matthewelwell
approved these changes
May 27, 2022
gagantrivedi
added a commit
that referenced
this pull request
May 27, 2022
* bump engine-test-data * fix: feature segment priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.