fix: Fix HTTP requests not timing out #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
force-pushed
the
fix/requests-timeout
branch
from
ccf292a to
eb6f7fd
Compare
emyller
changed the title
emyller
force-pushed
the
fix/requests-timeout
branch
from
eb6f7fd to
17068db
Compare
matthewelwell
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.
What is the problem
This: the default HTTP timeout (10 seconds) isn't used, leading to requests — under timeout-y circumstances — hanging for longer than stated in the docs.
How it was fixed
Respecting the default timeout.
How it was tested
Unit tests.