Add support for selection of protocols #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implement of the Call object being stateful, the retry logic was never triggered as an IllegalStateException was bypassing the normal flow. Closes: Flagsmith#144
The flagsmith config builder now accepts a list of supported protocols that can be used by the underlying HTTP client. Closes: Flagsmith#153
matthewelwell
approved these changes
Aug 19, 2024
Contributor
|
@olivier-hubaut apologies for the delay in reviewing this. The code looks good to me! Thanks very much for submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a fix for the issue described in #153