feat: change cache to use Map<String, Flag> instead of Set<Flag> #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing is the feature name.
emyller
requested changes
Jun 24, 2025
| @@ -357,7 +356,7 @@ class FlagsmithClient { | |||
| Future<bool> removeFeatureFlag(String featureName) async { | |||
| var result = await storageProvider.delete(featureName); | |||
| if (config.caches) { | |||
| _flags.removeWhere((element) => element.feature.name == featureName); | |||
| _flags.removeWhere((key, _) => key == featureName); | |||
There was a problem hiding this comment.
Suggested change
| _flags.removeWhere((key, _) => key == featureName); | |
| _flags.remove(featureName); |
Comment on lines
582
to
586
| if (config.caches) { | ||
| _flags.removeWhere((element) => element.feature.name == featureName); | ||
| _flags.removeWhere((key, _) => key == featureName); | ||
| if (value != null) { | ||
| _flags.add(value); | ||
| _flags[value.feature.name] = value; | ||
| } |
There was a problem hiding this comment.
if (config.caches && value != null) {
_flags[featureName] = value;
}
Comment on lines
+544
to
+551
| final newData = <String, Flag>{}; | ||
| for (var element in list) { | ||
| newData[element.feature.name] = element; | ||
| } | ||
|
|
||
| _flags | ||
| ..clear() | ||
| ..addAll(newData); |
There was a problem hiding this comment.
Suggested change
| final newData = <String, Flag>{}; | |
| for (var element in list) { | |
| newData[element.feature.name] = element; | |
| } | |
| _flags | |
| ..clear() | |
| ..addAll(newData); | |
| _flags.clear(); | |
| list.forEach((element) => _flags[element.feature.name] = element); |
We don't need the addAll after all. Feel free to keep the bare for syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I realised that the cached uses quite a number of
firstWhereOrNullfor lookup. This PR changes to use Map so that getting flag value will be in O(1). I am currently thinking of using this but would also like some opinion from original maintainer on this idea :)Unit test result