Skip to content

fix: Exclude identities when PERCENTAGE_SPLIT trait is undefined #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 1 commit into from
Nov 28, 2025
Merged

fix: Exclude identities when PERCENTAGE_SPLIT trait is undefined #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "Flagsmith.EngineTest/EngineTestData"]
path = Flagsmith.EngineTest/EngineTestData
url = git@github.com:Flagsmith/engine-test-data.git
tag = v3.4.2
tag = v3.5.0
2 changes: 1 addition & 1 deletion Flagsmith.Engine/Engine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ private static bool ContextMatchesCondition<_, __>(EvaluationContext<_, __> cont

if (contextValue != null)
objectIds = new List<string> { segmentKey, contextValue.ToString() };
else if (context.Identity?.Key != null)
else if (string.IsNullOrEmpty(condition.Property) && context.Identity?.Key != null)
objectIds = new List<string> { segmentKey, context.Identity.Key };
else
return false;
Expand Down
2 changes: 1 addition & 1 deletion Flagsmith.EngineTest/EngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void Test_Engine(String testCaseFilename)
var result = _iengine.GetEvaluationResult(testCase.Context);

// Then
Assert.Equivalent(testCase.Result, result);
Assert.Equivalent(testCase.Result, result, strict: true);
}

public static IEnumerable<object[]> ExtractTestCaseFilenames()
Expand Down
2 changes: 1 addition & 1 deletion Flagsmith.EngineTest/EngineTestData
Open in desktop
Submodule EngineTestData updated 1 files
+48 −0 test_cases/test_percentage_split__missing_trait__should_not_match.jsonc
Loading