Skip to content

fix!: Remove flag ID properties/methods #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolodato merged 2 commits into from
Dec 18, 2024
Merged

fix!: Remove flag ID properties/methods #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49caa83
Remove flag ID properties/methods
rolodato Dec 18, 2024
4278dbb
Bump version to 7.0.0
rolodato Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Flagsmith.FlagsmithClient/Flag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public Flag(Feature feature, bool enabled, string value, int featureId = default
this.Value = value;
this.Feature = feature;
}
[JsonProperty("id")]
public int Id { get; private set; }
[JsonProperty("feature")]
private Feature Feature { get; set; }

Expand All @@ -26,10 +24,6 @@ public Flag(Feature feature, bool enabled, string value, int featureId = default
[JsonProperty("feature_state_value")]
public string Value { get; private set; }

public int getFeatureId()
{
return this.Feature.Id;
}
public string GetFeatureName()
{
return this.Feature.Name;
Expand Down
2 changes: 1 addition & 1 deletion Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<PackageId>Flagsmith</PackageId>
<Title>Flagsmith</Title>
<Version>6.0.0</Version>
<Version>7.0.0</Version>
<Authors>flagsmith</Authors>
<Company>Flagsmith</Company>
<PackageDescription>Client SDK for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://flagsmith.com/</PackageDescription>
Expand Down
3 changes: 0 additions & 3 deletions Flagsmith.FlagsmithClient/IFlag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@
{
public interface IFlag
{
int Id { get; }
bool Enabled { get; }
string Value { get; }
int getFeatureId();
string GetFeatureName();
string ToString();
}
}
Loading