Skip to content

fix: handle null django_id in identity overrides for local evaluation mode #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewelwell merged 1 commit into from
Oct 30, 2024
Merged

fix: handle null django_id in identity overrides for local evaluation mode #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Flagsmith.Client.Test/Fixtures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ internal class Fixtures
'featurestate_uuid': '1bddb9a5-7e59-42c6-9be9-625fa369749f',
'feature_state_value': 'some-overridden-value',
'enabled': false,
'django_id': null,
'environment': 1,
'identity': null,
'feature_segment': null
Expand Down
4 changes: 2 additions & 2 deletions Flagsmith.Engine/Feature/Models/FeatureStateModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class FeatureStateModel
[JsonProperty(PropertyName = "multivariate_feature_state_values")]
public List<MultivariateFeatureStateValueModel> MultivariateFeatureStateValues { get; set; }
[JsonProperty(PropertyName = "django_id")]
public int DjangoId { get; set; }
public int? DjangoId { get; set; }
public string FeatureStateUUID { get; set; } = new Guid().ToString();
[JsonProperty(PropertyName = "feature_segment")]
public FeatureSegmentModel FeatureSegment { get; set; } = null;
Expand All @@ -33,7 +33,7 @@ public object GetMultivariateValue(string identityId)
{
var percentageValue = Hashing.GetHashedPercentageForObjectIds(new List<string>
{
DjangoId != 0 ? DjangoId.ToString() : FeatureStateUUID,
DjangoId != null ? DjangoId.ToString() : FeatureStateUUID,
identityId.ToString()
});
var startPercentage = 0.0;
Expand Down
2 changes: 1 addition & 1 deletion Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<PackageId>Flagsmith</PackageId>
<Title>Flagsmith</Title>
<Version>5.4.2</Version>
<Version>5.4.3</Version>
<Authors>flagsmith</Authors>
<Company>Flagsmith</Company>
<PackageDescription>Client SDK for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://flagsmith.com/</PackageDescription>
Expand Down