feat: add namespaceOverride support for sub-chart deployments #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Added
namespaceOverridesupport to allow deploying Flagsmith to a specific namespace when used as a sub-chart.Closes #452
flagsmith.namespacehelper in_helpers.tplthat returnsnamespaceOverrideif set, otherwise falls back to.Release.Namespace{{ include "flagsmith.namespace" . }}for the namespace fieldHow did you test this code?
Ran
helm templateand verified all Flagsmith resources havenamespace: flagsmith-nsin their metadataDeployed to minikube and verified all resources are created in the correct namespace and functioning properly
Verified default behavior (without
namespaceOverride) still uses the release namespace