Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Nov 21, 2025

Mapper test cases validate conversion from environment documents to evaluation contexts.

Changes

  • Add mapper_test_cases/ directory with test data
  • Add comprehensive mapper test case covering segments, features, identity overrides, and multivariate features
  • Update readme with mapper tests documentation

Warning

Mapper tests exist only to support safe deprecation of the environment document.

Review effort: 2/5

@emyller emyller requested a review from a team as a code owner November 21, 2025 22:08
@emyller emyller requested review from gagantrivedi and removed request for a team November 21, 2025 22:08
…conversion

Co-authored-by: Claude <noreply@anthropic.com>
@gagantrivedi
Copy link
Member

Is this part of the current sprint?

@emyller
Copy link
Contributor Author

emyller commented Dec 1, 2025

Is this part of the current sprint?

It was intended to, but we ultimately decided to release without this.

# Engine Test Data

> [!NOTE]
> Test case files may contain descriptions in JSON5-compliant comments. Test implementations should be ready to parse JSON5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say jsonc instead of json5?

@@ -0,0 +1,286 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this file does not have any comments? It can be just named .json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants