Skip to content

Conversation

Copy link

Copilot AI commented Oct 27, 2025

Added 12 new test cases for IN operator edge cases:

Native list condition properties:

  • float context value vs float[] condition property — should match
  • int context value vs int[] condition property — should match
  • float context value vs int[] condition property — should not match
  • int context value vs float[] condition property — should not match

Comma-delimited string condition properties:

  • float context value vs string comma-delimited floats condition property — should match
  • int context value vs string comma-delimited ints condition property — should match
  • float context value vs string comma-delimited ints condition property — should not match
  • int context value vs string comma-delimited floats condition property — should not match

JSON-encoded list condition properties:

  • float context value vs string JSON-encoded floats condition property — should match
  • int context value vs string JSON-encoded ints condition property — should match
  • float context value vs string JSON-encoded ints condition property — should not match
  • int context value vs string JSON-encoded floats condition property — should not match

All test cases follow the existing naming convention and structure, with descriptive comments explaining each scenario. Float values use 2.0 (vs int 2) to test ambiguous cases that are equal in loose comparison but distinct in type-strict comparison. Native array values are now strings to comply with the JSON schema.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: khvn26 <979078+khvn26@users.noreply.github.com>
Copilot AI changed the title [WIP] Add edge cases for In operator handling Add IN operator edge cases for int/float type matching Oct 27, 2025
Copilot AI requested a review from khvn26 October 27, 2025 17:18
Copilot finished work on behalf of khvn26 October 27, 2025 17:18
@khvn26
Copy link
Member

khvn26 commented Oct 27, 2025

@copilot for test cases involving floats, we should use values that add ambiguity when loosely compared — i.e. 2 vs 2.0, not 2.5.

… vs 2)

Co-authored-by: khvn26 <979078+khvn26@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 27, 2025

@copilot for test cases involving floats, we should use values that add ambiguity when loosely compared — i.e. 2 vs 2.0, not 2.5.

Updated all float test cases to use 2.0 instead of 2.5 for better ambiguity testing. Commit: 2abf80b

Copilot finished work on behalf of khvn26 October 27, 2025 17:29
@khvn26 khvn26 changed the title Add IN operator edge cases for int/float type matching feat: Add In operator edge cases Oct 27, 2025
@khvn26 khvn26 marked this pull request as ready for review October 27, 2025 17:30
@khvn26 khvn26 requested a review from a team as a code owner October 27, 2025 17:30
khvn26

This comment was marked as outdated.

@khvn26 khvn26 requested review from a team and Zaimwa9 and removed request for a team October 27, 2025 17:30
gagantrivedi
gagantrivedi previously approved these changes Oct 29, 2025
@khvn26 khvn26 self-requested a review October 29, 2025 09:00
@khvn26
Copy link
Member

khvn26 commented Oct 29, 2025

@copilot make sure the new test cases are compliant with their JSON schema — "value" array values should be arrays of (numeric) strings.

Co-authored-by: khvn26 <979078+khvn26@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 29, 2025

@copilot make sure the new test cases are compliant with their JSON schema — "value" array values should be arrays of (numeric) strings.

Updated native array values to use strings (e.g., ["1.0", "2.0", "3.0", "4.0"] instead of [1.0, 2.0, 3.0, 4.0]) to comply with the JSON schema. Commit: c8ed747

Copilot finished work on behalf of khvn26 October 29, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants