-
Notifications
You must be signed in to change notification settings - Fork 98
[Serve] Flagscale serve supports automatically composition of multiple models #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm not sure, maybe it's a better choice to implement it at a higher level (adding a new compose-mode with no changes in serve-mode) ? |
deploy: | ||
port: 6701 | ||
use_fs_serve: true | ||
enable_omposition: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this parameter means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable_composition means using composition of multiple models.
|
||
from dag_utils import check_and_get_port | ||
from fastapi import FastAPI, HTTPException, Request | ||
from pydantic import create_model | ||
from ray import workflow | ||
from ray import serve | ||
from ray.serve.handle import DeploymentHandle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need add ray version restrictions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, more ray versions will be tested later
flagscale/serve/engine.py
Outdated
|
||
from flagscale.logger import logger | ||
|
||
RequestData = create_model( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to deal with multimodal input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set config as follows:
deploy:
request:
args:
- prompt
- num
types:
- str
- int
As discussed, what you mentioned refers to combining different independent services, while this scenario focuses on combining multiple different models. Your idea will be taken into consideration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: ./.github/workflows/functional-tests.yml should be changed to uses: ./.github/workflows/functional-tests-nvidia.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
9f273a5
to
d4e58d0
Compare
Description
Flagscale serve supports automatically composition of multiple models
python run.py --config-path ./examples/qwen2_5/conf --config-name serve_multiple_models action=run