[Operator] simplify outer backward #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowen12992
approved these changes
Sep 5, 2024
DuanYaQi
pushed a commit
that referenced
this pull request
Sep 13, 2024
* [op] simplify outer backward to accelerate ci for blas * [tests] reduce the accuracy tests of addmm * [doc] update version2.1 change log * [no ci] pre-commit --------- Co-authored-by: Bowen12992 <zhangbo.sjtu@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Other
Description
use mv instead of mm for outer backward. thus ci/cd could finish in a short time.
and reduce tests of addmm as well, cause it doesn't need thousands of cases to prove the accuracy.
the cuda performance of outer backward isn't improved indeed. optimization to do on mv.
Issue
Progress
Performance