Skip to content

Add Swift workflow #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2020
Merged

Add Swift workflow #3

merged 9 commits into from
Oct 24, 2020

Conversation

SplittyDev
Copy link
Member

@SplittyDev SplittyDev commented Oct 2, 2020

Create GitHub action workflow for building and testing SchafKit on macOS.

Issues

Currently these tests are failing because the Swift distribution used in the workflow doesn't recognize new features of SwiftUI, which cause it to break. I'm looking into whether this can be fixed.

After updating the workflow, we're getting another error.
The issue is being tracked at: swift-actions/setup-swift#133

Generally, another issue is that this only tests the macOS-specific code.
Not sure if there's any way to actually test the iOS-specific code in an automated fashion.

@SplittyDev SplittyDev self-assigned this Oct 2, 2020
@SplittyDev SplittyDev added the enhancement New feature or request label Oct 2, 2020
@SplittyDev
Copy link
Member Author

@JannThomas please check the build error.

Screen Shot 2020-10-06 at 20 11 40

Is this a valid error?

@JannThomas
Copy link
Contributor

JannThomas commented Oct 6, 2020

There was a valid error in the iOS target (fixed with 63bf898). But none for the macOS target afaics.

@JannThomas
Copy link
Contributor

JannThomas commented Oct 6, 2020

The target SDK version seems to be 10.15.6. That is wrong. It should be 10.16 or 11.0, depending upon which is available. Can you do that? Doesn't make sense still that it does not compile, as the line in question is marked with @available(macOS 10.16, *).

@SplittyDev
Copy link
Member Author

The target SDK version seems to be 10.15.6. That is wrong. It should be 10.16 or 11.0, depending upon which is available. Can you do that?

I'm actually pretty sure that it's not possible to compile with 11.0 at the moment.
Screen Shot 2020-10-06 at 22 42 05

So I guess we'll either have to somehow make this work with macOS 10.15 or wait for release.

Doesn't make sense still that it does not compile, as the line in question is marked with @available(macOS 10.16, *)

With your annotation that should work though..

@JannThomas
Copy link
Contributor

I guess we'll just have to wait 🤷🏻‍♂️

@JannThomas JannThomas merged commit ce355cf into master Oct 24, 2020
@JannThomas JannThomas deleted the add-swift-workflow branch October 24, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants