Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
collectionIdis 0.When
GetCache(0, ...)is called for the first time_cache.Countbecomes 1 and_cacheCountremains 0.As a result, we always go into the
if (collectionId >= _cacheCount)check and try to fill_cacheeven though it is already filled.And when we call
ClearPool(), theif (spawnableCollectionId >= _cacheCount)check prevents us from going any further because_cacheCountis 0 and we will never clear the pool.With this fix we remember the real size of the cache and solve both problems - we don't try to re-fill the already filled cache and allow to clear the default pool collection.