RPC logic calling inherited type always calls base.

[FirstGearGames]

Reported by Discord Id !@890806465835716659

https://discord.com/channels/424284635074134018/1034477094731784302/1390808006874107934

public class GameModeManager : NetworkBehaviour
{
    public TeamDeathMatch Active;

    public override void OnStartServer()
    {
        base.OnStartServer();
        StartGameMode();
    }

    [ObserversRpc]
    private void StartGameMode()
    {
        Active.OnStartGameModeClientSide(); // Logs "GameplayModeStarted TeamDeathMatch"
    }
}

public class GameplayMode : NetworkBehaviour
{
    public virtual void OnStartGameModeClientSide()
    {
        Debug.Log($"GameplayModeStarted {this.GetType().Name}");
    }
}

public class TeamDeathMatch : GameplayMode
{
    public override void OnStartGameModeClientSide()
    {
        Debug.Log($"TeamDeathMatchStarted {this.GetType().Name}");
    }
}

[FirstGearGames]

Confirmed.

• Open scene 938.
• Press play -- see 'called as parent.

Issue_983.zip

Expected 'called as child' text.

[FirstGearGames]

Resolved in 4.6.10.

In RpcProcessor.cs find method

private MethodDefinition CreateRpcLogicMethod(List<AttributeData> datas, CreatedRpc cr, out bool intentionallyNull)

Scroll down to this line within method.

#if !UNITY_2022_3_OR_NEWER

Replace within between #if !UNITY_2022_3_OR_NEWER and #endif with this.

            /* If the declaring type has a generic then we need to see if any
             * logic instructions call methods in another or same generic class. */
            ILProcessor processor = createdMd.Body.GetILProcessor();
            List<Instruction> inserter = new();

            //base.LogWarning($"Created {createdMd.Name}. Original {cr.OriginalMethodDef.Name}");
            Collection<Instruction> instructions = createdMd.Body.Instructions;
            for (int i = 0; i < instructions.Count; i++)
            {
                inserter.Clear();

                Instruction v = instructions[i];
                OpCode instrOpCode = v.OpCode;
                
                if (instrOpCode == OpCodes.Callvirt || instrOpCode == OpCodes.Call)
                {
                    MethodDefinition calledMd = null;

                    if (v.Operand is MethodDefinition md)
                    {
                        calledMd = md;
                    }
                    else if (v.Operand is MethodReference mr)
                    {
                        //If methodReference declaring type has generics.
                        if (mr.DeclaringType.ContainsGenericParameter)
                            calledMd = mr.CachedResolve(Session);
                    }

                    //If need to make a new call then remove old and insert.
                    if (calledMd != null)
                    {
                        instructions.RemoveAt(i);
                        inserter.Add(processor.Create(instrOpCode, calledMd));
                        processor.InsertAt(i, inserter);
                    }
                }
            }