Nested networkobjects incorrectly spawned when parent networkobject is inactive in scene

[gregharding]

General
Unity version: 6.1.3f1
Fish-Networking version: 4.6.9 (latest)
Discord link: Discord message
Related to: #897

Description
After a server is started, hierarchies of nested networkobjects that have a parent networkobject gameobject which is inactive in the scene are spawned incorrectly. The parent scene networkobject does not spawn because its gameobject is inactive which is the expected behaviour.

Replication
Steps to reproduce the behavior:

1. In the repro project open the 'test' scene.
2. Observe in the scene that there is an inactive hierarchy of network objects under "canary holder".
3. Press play, start a server with the FishNet UI.
4. Check the console which logs spawned networkobjects after 'OnStartServer'.
5. See that a nested networkobject "canary nested" has unexpectedly spawned, but the parent "canary holder"
   has not.

Expected behavior
None of the inactive scene networkobjects should spawn when the server starts because the root gameobject is inactive.

[FirstGearGames]

Did you try rebuilding the scene Ids by any chance? That also reserializes other things related to spawning

[gregharding]

Did you try rebuilding the scene Ids by any chance? That also reserializes other things related to spawning

Yes, in our main project we tried reserialising everything without any effect. The nested networkobjects are still incorrectly spawning while the parent remains unspawned as expected. The test project above should be pretty clean too. I just ran the tool to reserialise everything in the scene and it still shows the issue.

[FirstGearGames]

Thanks again for the find. The fix was simple.

Find this line in ServerObjects.cs

                if (nob.GetIsNetworked() && nob.IsSceneObject && nob.IsDeinitializing)

Replace with these lines.

                //Requirement: parent spawned or no parent, isNetworked, isSceneObject, and is deinitialized (not already spawned/spawning).
                bool parentIsSpawned = (nob.CurrentParentNetworkBehaviour  == null || nob.CurrentParentNetworkBehaviour.IsSpawned);
                if (parentIsSpawned && nob.GetIsNetworked() && nob.IsSceneObject && nob.IsDeinitializing)

Resolved in 4.6.10

[gregharding]

Thanks again for the find. The fix was simple.
Resolved in 4.6.10

I tested this patch in the test project (submitted above) and a full project and it works fine - inactive hierarchies of scene objects have no issues.