-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade SDK version to alpha2 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ewoutkramer
merged 46 commits into
develop-sdk6
from
feature/upgrade-sdk-to-6.0.0-alpha2
Jun 18, 2025
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
eac0157
Upgrade SDK to 6.0.0-alpha
andrzejskowronski bddf836
Merge branch 'develop' into feature/upgrade-sdk-to-6.0.0-alpha1
andrzejskowronski c02588f
Fix some test cases
andrzejskowronski 60b5715
Temporary fix
andrzejskowronski 3041125
changed a bit of logic in the EC validator to use Resource variable c…
Kasdejong 3867150
Merge branch 'develop' into feature/upgrade-sdk-to-6.0.0-alpha1
andrzejskowronski 25fcfc0
First batch of changes
Kasdejong 9acab0a
wip
Kasdejong d442c58
fixed all unit tests apart from the ones that are blocked for now. Th…
Kasdejong c941517
reduced version to alpha2
Kasdejong e1985fb
Merge remote-tracking branch 'refs/remotes/origin/develop-sdk6' into …
Kasdejong e9b4e06
made all sdk versions appropriate
Kasdejong ad1dcf6
All tests should be up and running now, thanks to the packages librar…
Kasdejong 8b2093e
Merge remote-tracking branch 'origin/develop' into feature/upgrade-sd…
Kasdejong 39e7b12
this should still be disabled for now... It will be enabled in the ex…
Kasdejong fd88c3e
forgot to disable this test again
Kasdejong 719771f
PR requested changes
Kasdejong 3b61625
Merge branch 'develop-sdk6' into feature/upgrade-sdk-to-6.0.0-alpha2
Kasdejong a9301dd
manifest tests
Kasdejong 1026bde
Update StructureDefinitionCorrectionsResolver.cs
Kasdejong 0fa120f
Solved compiler issues, removed incorrect suggestion by Copilot.
ewoutkramer 8d4044c
manifest update
Kasdejong 226333a
re enabled ignore statement
Kasdejong 0ff294e
hoping this is the right version at last
Kasdejong 31f49a7
new manifest version
Kasdejong f366e28
manifest updates
Kasdejong b2500cf
?
Kasdejong b8aeda2
manifest updates
Kasdejong d5ec9d7
manifest changes after resetting artifact cache
Kasdejong c73b777
updated version
Kasdejong 804d382
updated version again
Kasdejong cc4b694
added new import
Kasdejong 2b6ac26
Merge branch 'develop-sdk6' into feature/upgrade-sdk-to-6.0.0-alpha2
Kasdejong e261426
merged newest sdk-5 validator into this
Kasdejong cb860a4
merge errors
Kasdejong 59e6fd4
All changes for the manifest, up to date with develop this time
Kasdejong cbb3894
added extra potential source of position information to the issue ass…
Kasdejong 7142677
changes to manifest after updating sdk (fixing bugs in SDK)
Kasdejong ea3b7fa
changes to manifest after updating sdk (fixing bugs in SDK)
Kasdejong 6bc7efa
Merge remote-tracking branch 'origin/feature/upgrade-sdk-to-6.0.0-alp…
Kasdejong 59924f3
did not work... pushing again
Kasdejong 0dec6ea
added position info for primitives (valueElementNode)
Kasdejong bec3036
fixed value element node annotations
Kasdejong 2d934ae
Fixed sdk crashing and erasing all errors when a version was found on…
Kasdejong 82f5f0c
Changed manifest to reflect new SDK version. this will fail on the pi…
Kasdejong ce2d668
correct package version now that the required changes are pushed to g…
Kasdejong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 2 additions & 1 deletion
3
.idea/.idea.Firely.Validator.API/.idea/projectSettingsUpdater.xml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
398 changes: 199 additions & 199 deletions
398
src/Firely.Fhir.Validation.Compilation.Shared/StructureDefinitionCorrectionsResolver.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #513, we should not disable those warnings once PR is ready :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a TON of effort right now!!! I have well over 1000 of these errors because our model is now nullable! We should make a separate issue for this once the dust settles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Can you create a PR for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(aaah.....we don't have the preview of this new copilot stuff :-()