-
Couldn't load subscription status.
- Fork 354
2936 Make comparisons consistent #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
|
On nullability of |
# Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
This PR removes comparisons from the FHIR types, in favor of using the comparisons on the CQL types. Also, it simplifies the public surface of the CQL types:
IToSystemPrimitivefor consistently converting from a FHIR primitive to a CQL primitive.@Kasdejong : The last feature will make sure that doing comparisons in FhirPath is a simple
IToSystemPrimitive.TryConvertToSystemType()plus +TryCompare(). We should refactor that in the FP engine.Still Todo:
nullif the Value of the primitive was null. I have now removed that, but double check that that makes sense. Esp with TryXXX: would you return false if you would return null if there is no value, or is that allowed?Fixes #2936, also fixes #2932.