Skip to content

6.0/2923 Make serialization use new serializers #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 13, 2025
Merged

6.0/2923 Make serialization use new serializers #3002

merged 12 commits into from
Jan 13, 2025

Conversation

@ewoutkramer
Copy link
Member

@ewoutkramer ewoutkramer commented Jan 6, 2025 •
edited
Loading

Fixes #2923.

⚠️ This PR cleans up the serialization API, mostly getting rid of similar but different serializer settings. This is probably one of the biggest batches of changes to the public surface, so it has its own section here: https://github.com/FirelyTeam/firely-net-sdk/wiki/Breaking-changes-in-6.0#breaking-changes-to-the-serializers

I have not yet done some renames because it would make reviewing harder. So after review, this still needs to be done:

  • Rename CommonFhirXml/JsonSerializer -> BaseFhirXml/JsonSerializer
  • CommonFhirXml/JsonSerializerExtensions -> Xml/JsonSerializerExtensions
  • Of course, rename the files.

@ewoutkramer ewoutkramer changed the title 6.0/2923 make serialization use new serializers 6.0/2923 Make serialization use new serializers Jan 8, 2025
@ewoutkramer
Reshuffled everything so FhirXmlSerializer/FhirJsonSerializer become …
2c896be 
…the main serializers.
@ewoutkramer
Some more surface improvements.
d8d75b5 
Made the obsolete Newtonsoft function work via the new serializers
Removed subsetting functions from the POCO surface.
@ewoutkramer
Merge branch 'develop-6.0' into 6.0/2923-make-serialization-use-new-s…
617bcd2 
…erializers
@ewoutkramer ewoutkramer marked this pull request as ready for review January 9, 2025 10:37
@ewoutkramer ewoutkramer enabled auto-merge January 9, 2025 10:37
@ewoutkramer ewoutkramer requested a review from mmsmits January 9, 2025 10:38
@ewoutkramer ewoutkramer requested a review from mmsmits January 10, 2025 16:00
@ewoutkramer
Copy link
Member Author

ewoutkramer commented Jan 10, 2025 •
edited
Loading

I have now documented all serialization functions and extensions, as requested verbally by @mmsmits.

@ewoutkramer ewoutkramer merged commit 46c6e14 into develop-6.0 Jan 13, 2025
16 checks passed
@ewoutkramer ewoutkramer deleted the 6.0/2923-make-serialization-use-new-serializers branch January 13, 2025 13:17
This was referenced Oct 15, 2025
Open
Open
Open
Open
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmsmits mmsmits mmsmits approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewoutkramer @mmsmits