Skip to content

Conversation

@mmsmits
Copy link
Member

@mmsmits mmsmits commented Nov 18, 2024

This pull request includes several changes to the Hl7.Fhir.Base library, focusing on enhancing the ValidateCodeParameters class and associated functionality. The most important changes include adding a new attribute inferSystem, modifying validation logic, and updating relevant tests.

Enhancements to ValidateCodeParameters:

  • Added a new private constant URLATTRIBUTE in ParametersExtensions.cs to support URL-based validation.
  • Introduced a new attribute inferSystem in the ValidateCodeParameters class, along with corresponding getter and setter methods. [1] [2] [3]
  • Updated the WithCode method in ValidateCodeParameters.cs to include the inferSystem parameter.

Validation logic updates:

  • Changed the validation logic in CheckForValidityOfValidateCodeParams to require a URL or context instead of a system or context.
  • Updated error messages in LanguageTerminologyServiceTests.cs and MimeTypeTerminologyServiceTests.cs to reflect the new validation logic. [1] [2]

Test updates:

  • Added new tests in TerminologyTests.cs to verify the functionality of ValidateCodeParameters with the new inferSystem attribute and URL-based validation.

@mmsmits mmsmits marked this pull request as ready for review November 21, 2024 11:11
@mmsmits mmsmits requested a review from ewoutkramer November 21, 2024 11:11
@mmsmits mmsmits enabled auto-merge November 21, 2024 12:34
@mmsmits mmsmits merged commit 40ae960 into develop Nov 22, 2024
16 checks passed
@mmsmits mmsmits deleted the bugfix/2854-fix-validate-code branch November 22, 2024 07:58
@ewoutkramer
Copy link
Member

This fixes #2854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants