Skip to content

Base POCO parsers/serializers on POCO, not IROD #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2024
Merged

Base POCO parsers/serializers on POCO, not IROD #2950

merged 8 commits into from
Nov 13, 2024

Conversation

@ewoutkramer
Copy link
Member

@ewoutkramer ewoutkramer commented Oct 23, 2024 •
edited
Loading

  • ⚠️ BREAKING: Based the parsers/serializers on Base instead of IReadOnlyDictionary<>. Should not really matter, since internally, the code required the things to be subclasses of Base anyway to function correctly.
  • Added extensions so subtrees van be serialized, if the underlying engine is our new POCO serializer
  • Added extensions so one can serialize to/from streams, if the underlying engine is our new POCO serializer.
  • ⚠️ BREAKING: Removed the obsolete FhirJsonConverter constructors (use the ForFhir extension methods on JsonSerializerOptions).
  • ⚠️ BREAKING: Renamed methods on the IFhirSerializationExtensions, since they made no sense (e.g. DeserializeReaderToJson has become DeserializeFromJsonReader).

Fixes #2917.

@ewoutkramer
WIP
2d8a0d2
@ewoutkramer
Merge remote-tracking branch 'origin/move-to-netstandard-2.1' into 6.…
b7e8886 
…0/parse-elements-for-xml-parsers
@ewoutkramer
Base parsers on POCO, not IROD. Also, improve XML subtree serialization.
a5736b5
@ewoutkramer
Merge branch 'develop-6.0' into 6.0/parse-elements-for-xml-parsers
d0ba6ad 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
@ewoutkramer
Merge branch 'develop-6.0' into 6.0/parse-elements-for-xml-parsers
26f0190 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
#	src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoSerializer.cs
#	src/Hl7.Fhir.Base/Serialization/FhirJsonConverter.cs
ewoutkramer
ewoutkramer commented Oct 23, 2024
View reviewed changes
@ewoutkramer ewoutkramer mentioned this pull request Oct 23, 2024
Closed
@ewoutkramer ewoutkramer requested a review from Kasdejong October 23, 2024 17:17
Kasdejong
Kasdejong reviewed Oct 24, 2024
View reviewed changes
Kasdejong
Kasdejong requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Kasdejong Kasdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally set the review to "comment" instead of "request changes", this should tag it appropriately

@ewoutkramer ewoutkramer merged commit e169b06 into develop-6.0 Nov 13, 2024
16 checks passed
@ewoutkramer ewoutkramer deleted the 6.0/parse-elements-for-xml-parsers branch November 13, 2024 14:54
This was referenced Oct 15, 2025
Open
Open
Open
Open
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kasdejong Kasdejong Kasdejong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewoutkramer @Kasdejong