Use proper snapshot generation settings, fixed obsolete warnings #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old behaviour. There is still a key difference in root elementDef handling
Kasdejong
changed the title
… old behaviour. There is still a key difference in root elementDef handling
…ration-settings' into feature/use-proper-snapshot-generation-settings # Conflicts: # src/Hl7.Fhir.Conformance/Specification/Snapshot/SnapshotGenerator.cs # src/Hl7.Fhir.STU3/Specification/Snapshot/SnapshotGenerator.cs
…is should not be used.
Kasdejong
changed the title
ewoutkramer
requested changes
Oct 22, 2024
| public SnapshotEvaluationContext( | ||
| string testPath, IResourceResolver resolver, string id, | ||
| StructureDefinition input, StructureDefinition generated) : base(generated.ToTypedElement()) | ||
| StructureDefinition input, StructureDefinition generated) |
There was a problem hiding this comment.
Shouldn't this set the WithResource()?
| Assert.AreEqual("contained-1", patBundle.Scalar("%resource.id", ctx)); | ||
| Assert.AreEqual("patient-1", patBundle.Scalar("%rootResource.id", ctx)); | ||
| testNode = patBundle.Select("entry.first().resource.contained.id")?.FirstOrDefault() as ScopedNode; | ||
| ctx = new FhirEvaluationContext(); |
There was a problem hiding this comment.
Do we need to re-create a new context every time?
ewoutkramer
approved these changes
Oct 22, 2024
Kasdejong
added
the
breaking change
ewoutkramer
deleted the
feature/use-proper-snapshot-generation-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description