Make Base implement IScopedNode - phase 1 #2913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copednode' into spike/make-resource-implement-iscopednode # Conflicts: # src/Hl7.Fhir.Serialization.R4.Tests/RoundtripSignature.cs
ewoutkramer
changed the title
ewoutkramer
changed the title
ewoutkramer
changed the title
ewoutkramer
changed the title
…copednode' into spike/make-resource-implement-iscopednode
ewoutkramer
requested changes
Oct 16, 2024
|
Serialization is still binary breaking, but not source breaking. It now takes Base instead of Resource |
…igator removed IBaseElementNavigator<T>
ewoutkramer
requested changes
Oct 18, 2024
src/Hl7.Fhir.Base/Serialization/engine/ElementModelSerializationEngine.cs
Show resolved
Hide resolved
…node # Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml # src/Hl7.Fhir.Base/Model/Base.cs
…copednode' into spike/make-resource-implement-iscopednode
ewoutkramer
requested changes
Oct 21, 2024
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> |
There was a problem hiding this comment.
Make sure you add info about the breaking changes to the PR, including alternatives that people can use.
src/Hl7.Fhir.Base/Serialization/engine/ElementModelSerializationEngine.cs
Show resolved
Hide resolved
|
Note: We will investigate to what extent this is breaking after we work our way through the. [TemporarilyChanged] annotations. |
ewoutkramer
approved these changes
Oct 22, 2024
ewoutkramer
changed the title
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This first step makes POCO's implement ITypedElement. Since we no longer supply an
ITypedElement.Definition, we had to patch some of the parsers to get all unit-tests back to work. In the end, these changes to the parsers will be reverted, they are just made to be able to continue testing with our extensive set of tests on ITypedElement.Related issues
#2894, #2895
Testing
Tested by making Base.ToTypedElement() point to this implementation. This is temporary.