Remove all non-inheritable extensions from the base profile before snapshotting #2886
Conversation
| // Also ignore any Changed extensions on base and diff | ||
| elemClone.RemoveAllConstrainedByDiffExtensions(); | ||
| baseClone.RemoveAllConstrainedByDiffExtensions(); | ||
| elemClone.RemoveAllNonInheritableExtensions(); |
There was a problem hiding this comment.
Does this method replace the original ones? So RemoveallNonInheritableExtension replaces RemoveAllConstrainedByDiffExtensions? If so, should we not remove/obsolete the original method?
There was a problem hiding this comment.
Well, I thought about that, but didn't dare to since Forge might be using the ConstraintByDiff extension one maybe?
And that is a bit faster (I don't know if it might be noticeable in a UI).
@Rob5045 any feedback here?
There was a problem hiding this comment.
Forge does not use the RemoveAllConstrainedByDiffExtensions extension.
There was a problem hiding this comment.
Thanks, I'll Obsolete is then
There was a problem hiding this comment.
I'm working on supporting extensions on element definition properties in Forge. That would mean that the UI won't be cluttered with these I guess? That would be nice.
There was a problem hiding this comment.
How about http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName? I see that one all the time as well.
There was a problem hiding this comment.
This is not on the list:
We only made this fix for category 5 of this list:
https://jira.hl7.org/browse/FHIR-28441?focusedCommentId=177188&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-177188
…xtensions-from-base
…xtensions-from-base
…ritable-extensions-from-base' into feature/1814-remove-all-non-inheritable-extensions-from-base
src/Hl7.Fhir.Base/Specification/Snapshot/SnapshotGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Base/Specification/Snapshot/SnapshotGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
…nsions.cs Co-authored-by: Ewout Kramer <ewout@fire.ly>
…nsions.cs Co-authored-by: Ewout Kramer <ewout@fire.ly>
…xtensions-from-base
…xtensions-from-base
mmsmits
deleted the
feature/1814-remove-all-non-inheritable-extensions-from-base
branch
fixes #1814