#2610 signal duplicate properties while parsing #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while-parsing # Conflicts: # src/firely-net-sdk-tests.props
…ed extra unit tests
ewoutkramer
requested changes
Feb 13, 2024
src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoDeserializer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ewout Kramer <ewout@fire.ly>
Co-authored-by: Ewout Kramer <ewout@fire.ly>
|
We broke it with our last change! It did work before. So maybe the cast can result in null after all? |
No, that does not make sense, as the |
|
With the compiler hint, the code works though... Could it be a runtime type error (nullable/non-nullable)? EDIT: it was a compiler failure, so this works now :) |
ewoutkramer
approved these changes
Feb 15, 2024
ewoutkramer
deleted the
feature/2610-signal-duplicate-properties-while-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSON deserializer should now correctly identify and report duplicate property keys
Related issues
Resolves issue #2610.
Testing
Unit tests added to assert (fatal) duplicate property keys errors and to assert their differentiation from (recoverable) duplicate array key errors.