[Validator] Also validate the instance type when the definition has children #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-when-validating-children
ewoutkramer
requested changes
Sep 14, 2022
| } | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
This block should move to line 41 (so just under var instanceType = ModelIInfo.FhirTypeNameToFhirType(..) : it's applicable to both choice and non-choice elements.
| { | ||
| // Only one type present in list of typerefs, all of the typerefs are candidates | ||
| outcome.Include(validator.ValidateTypeReferences(typeRefs, instance, state)); | ||
| validator.Trace(outcome, "ElementDefinition is a choice or contains a polymorphic type constraint, but the instance does not indicate its actual type", |
There was a problem hiding this comment.
This should not be a reachable code path when choices.Count() = 1.
ewoutkramer
approved these changes
Sep 14, 2022
ewoutkramer
deleted the
bugfix/2183-also-validate-parent-type-when-validating-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2183