Bugfix/2106 terminologyserviceexpand #2225
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ee4dfb8f1fb77d8f337413abac760d89c42ad712)
|
It is certainly a change in behaviour of the client towards the server - but it was really a bug on our side. So I think we don't have to wait for a major release. @marcovisserFurore - what do you think? |
ewoutkramer
previously approved these changes
Sep 7, 2022
|
I think this PR not a breaking change, because the external terminology servers are tolerant with the old parameter, and should also support the new But should this change not also be in the other versions, like STU3, R4? @brianpos ? |
marcovisserFurore
dismissed
ewoutkramer’s stale review
The base branch was changed.
marcovisserFurore
approved these changes
Sep 20, 2022
marcovisserFurore
added a commit
that referenced
this pull request
Sep 20, 2022
…ceexpand Bugfix/2106 terminologyserviceexpand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the parameter to be conformant with the R4+ specification
Update the URL of the CSIRO test server to use the R4 server, not STU3 endpoint.
(Not sure if you'd mark this as a breaking change, but it's now conformant with the R4 spec, would have been working with many terminology servers as they've been tolerant of the old parameter name)
Related issues
Resolves #2106
Testing
Unit test InvokeExpandExistingValueSet updated to also cover this code path.