Signing the NuGet Packages #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The produced nuget packages are now signed by a code signing certificate of Firely.
The public key is installed at NuGet for the organization Firely, and the private key is stored at a Azure Key Vault, together with the password for this key. To access those secrets in the Azure Key Vault a Variable Group
CodeSigninghas been created in the Devops projectfirely-net-sdk.The signing itself is done by a Firely template, which can be found here.
Also the flag
/p:ContinuousIntegrationBuild=truehas been added to the build to make the compilation deterministic.Related issues
Resolves issue #2012
FirelyTeam Checklist