Changes to improve performance of Bundle validation (R3) #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready been validated. Avoiding duplicate validation will keep bundle validation perf reasonable (we hope).
ewoutkramer
changed the title
marcovisserFurore
requested changes
Mar 28, 2022
| new CachedResolver( | ||
| new MultiResolver( | ||
| new TestProfileArtifactSource(), | ||
| new ZipSource("specification.zip"), |
There was a problem hiding this comment.
I prefer ZipSource.CreateValidationSource()
There was a problem hiding this comment.
Ah, right....I just copied this code, so I'll need to track down where I copied it from too....
marcovisserFurore
approved these changes
Mar 28, 2022
marcovisserFurore
deleted the
feature/bundle-validation-perf-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added state to keep track of which (nested/contained)resources have already been validated.
Avoiding duplicate validation will keep bundle validation perf reasonable (we hope).