Add NpmPackageResolver [STU3] #1879
Conversation
There was a problem hiding this comment.
The project Firely.Fhir.Packages has been added to the SDK and included in the Azure Pipelines. Also it can now be compiled against netstandard1.6.
The following steps that we still need to make are:
- reduce the number of public methods/classes
- polish the code to make it publishable.
…ure/npm-package-resolver # Conflicts: # common
…functionalities_stu3 # Conflicts: # common
…ure/npm-package-resolver # Conflicts: # common
mmsmits
changed the base branch from
develop-stu3
to
release/4.0.0-beta1-stu3
mmsmits
changed the title
…functionalities_stu3 # Conflicts: # common
…eature/include_package_functionalities_stu3 # Conflicts: # common
mmsmits
changed the base branch from
release/4.0.0-beta1-stu3
to
release/4.0.0-beta2-stu3
…eature/include_package_functionalities_stu3
…he CorePackageSource
…functionalities_stu3
Hl7.Fhir.sln
Outdated
| @@ -1,5 +1,6 @@ | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio Version 17 | |||
| VisualStudioVersion = 17.0.31710.8 | |||
There was a problem hiding this comment.
I think it is harmless to have 2 similar properties, but I'd rather have 1.
| @@ -789,7 +789,9 @@ public async T.Task CheckSdf8Expression() | |||
| public void TestXsdValidationExplicitSet() | |||
| { | |||
| var mySettings = _validator.Settings.Clone(); | |||
| mySettings.XsdSchemaCollection = new SchemaCollection(ZipSource.CreateValidationSource()); | |||
| var source = new FhirPackageResolver(ModelInfo.ModelInspector, "hl7.fhir.r3.corexml-3.0.2.tgz"); | |||
There was a problem hiding this comment.
Perhaps adding this hl7.fhir.r3.corexml-3.0.2.tgz to a variable, which can be used later in other unit tests?
There was a problem hiding this comment.
I see that there is already a private constant CorePackageSource.PACKAGENAME. Perhaps make that public and use it here?
|
|
||
| private IArtifactSource createXmlSource() | ||
| { | ||
| return new FhirPackageResolver(ModelInfo.ModelInspector, "hl7.fhir.r3.corexml-3.0.2.tgz"); |
There was a problem hiding this comment.
Use the const CorePackageSource.PACKAGENAME as well?
marcovisserFurore
deleted the
feature/include_package_functionalities_stu3
branch
No description provided.