Skip to content

Conversation

@ewoutkramer
Copy link
Member

@ewoutkramer ewoutkramer commented Mar 30, 2021

Fixed a bug where a discriminator walking into a complex extension would not find the complex child extension.

Created a (valid) example of a profile that constrains a complex extension inline and fixed the walker to look for fixUri instead of a targetProfile.profile.

Related issues

Fixes #1656.

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

…uld not find the complex child extension.

Created a (valid) example of a profile that constrains a complex extension inline and fixed the walker to look for fixUri instead of a targetProfile.profile.
@ewoutkramer ewoutkramer changed the title 1656: Can now use a discriminator to walk into a complex extension Fix 1656: Can now use a discriminator to walk into a complex extension (for R3) Mar 30, 2021
@marcovisserFurore marcovisserFurore changed the title Fix 1656: Can now use a discriminator to walk into a complex extension (for R3) Can now use a discriminator to walk into a complex extension (for R3) Mar 30, 2021
Copy link
Contributor

@marcovisserFurore marcovisserFurore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small (non functional) remark:

@marcovisserFurore marcovisserFurore merged commit b9133bd into develop-stu3 Mar 30, 2021
@marcovisserFurore marcovisserFurore deleted the feature/1656-discriminating-complex-extensions branch March 30, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElementDefinition.slicing.discriminator.path for complex Extensions

3 participants