This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Adding setting Serialize settings IncludeMandatoryToElements #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
suggested changes
Apr 1, 2021
| /// <summary> | ||
| /// Include mandatory elements to the given set elements | ||
| /// </summary> | ||
| public bool IncludeMandatoryToElements { get; set; } = false; |
There was a problem hiding this comment.
Nothing technical, but I did not "get" the name when I read it. I'll try a few alternatives:
- IncludeMandatoryInElementsSummary
- ElementsShouldIncludeMandatory
- IncludeMandatoryWithElements
The comment: "Include mandatory elements when serializing a subset of chosen elements (_elements). See .
There was a problem hiding this comment.
Let's do the first one then.
ewoutkramer
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves FirelyTeam/firely-net-sdk#1653