(For 2973) Remove Children/Namedchildren #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kasdejong
reviewed
Nov 20, 2024
For now, that is correct. We will have a public interface that we are designing right now that will act as "the" Base interface to navigate to children. But I intend to not have IReadOnlyDictionary return as an interface on the POCO's. It's too noisy, and some frameworks (and debuggers) are tempted to "smart" things with it (like display it as a dictionary in the debugger) that I really don't want to. But let's see what kind of feedback we get when we remove IDictionary ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generation changes for FirelyTeam/firely-net-sdk#2973