Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for packed attestation with x5c present #63

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Dec 7, 2023

I've acquired a device that produces this format, added the test vector from it, and confirmed the implementation based on the spec using said test vector.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2638034) 85.27% compared to head (1103388) 85.11%.

Files Patch % Lines
src/Attestations/Packed.php 74.50% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
- Coverage     85.27%   85.11%   -0.16%     
- Complexity      256      270      +14     
============================================
  Files            27       27              
  Lines           815      860      +45     
============================================
+ Hits            695      732      +37     
- Misses          120      128       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit ba0145b into main Dec 7, 2023
8 of 10 checks passed
@Firehed Firehed deleted the packed-x5c branch December 7, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant