Refactor join types #8606
Merged
Refactor join types #8606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dyemanov
commented
Jun 17, 2025
dyemanov
commented
- Replace BLR join verbs with enum inside RseNode
- Introduce ANTI JOIN
- Separate special join types (SEMI | ANTI) from INNER JOINs
…pecial joins. The optimizer is mostly ready for anti-joins.
asfernandes
reviewed
Jun 18, 2025
src/jrd/RecordSourceNodes.h
Outdated
| @@ -715,6 +715,21 @@ class WindowSourceNode final : public TypedNode<RecordSourceNode, RecordSourceNo | |||
|
|
|||
| class RseNode final : public TypedNode<RecordSourceNode, RecordSourceNode::TYPE_RSE> | |||
| { | |||
| enum : UCHAR // storage is BLR-compatible | |||
| { | |||
| INNER_JOIN = 0, | |||
There was a problem hiding this comment.
Isn't better to assign the blr constants?
INNER_JOIN = blr_inner,
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.