Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make return-type a compilation error #8362

Merged
merged 1 commit into from
Dec 26, 2024
+3 −1
Merged

Make return-type a compilation error #8362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds/posix/make.defaults
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ GLOB_OPTIONS:=
#____________________________________________________________________________

# Global c++ flags: firebird needs no RTTI, choose build standard and c++ specific warnings level
PLUSPLUS_FLAGS:= -fno-rtti -std=c++17 -Werror=delete-incomplete
PLUSPLUS_FLAGS:= -fno-rtti -std=c++17 -Werror=delete-incomplete -Werror=return-type

# If this is defined then we use special rules useful for developers only
IsDeveloper = @DEVEL_FLG@
Expand Down
1 change: 1 addition & 0 deletions builds/win32/msvc15/FirebirdCommon.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<UseFullPaths>false</UseFullPaths>
<MultiProcessorCompilation>true</MultiProcessorCompilation>
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<TreatSpecificWarningsAsErrors>4715</TreatSpecificWarningsAsErrors>
</ClCompile>
<Link>
<SuppressStartupBanner>true</SuppressStartupBanner>
Expand Down
1 change: 1 addition & 0 deletions src/common/CvtFormat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,7 @@ namespace
return twelveHours == 12 ? twelveHours : 12 + twelveHours;

cb->err(Arg::Gds(isc_incorrect_hours_period) << string(period.data(), period.length()));
ilya071294 marked this conversation as resolved.
Show resolved Hide resolved
return 0; // suppress compiler warning/error
}

constexpr int roundYearPatternImplementation(int parsedRRValue, int currentYear)
Expand Down
Loading