Skip to content

Ensure the standalone CS listener on Linux uses the SO_REUSEADDR socket option #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Ensure the standalone CS listener on Linux uses the SO_REUSEADDR socket option #8181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions src/remote/inet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,7 +1074,7 @@ static rem_port* listener_socket(rem_port* port, USHORT flag, const addrinfo* pa
* binds the socket and calls listen().
* For multi-client server (SuperServer or SuperClassic) return listener
* port.
* For classic server - accept incoming connections and fork worker
* For Classic server - accept incoming connections and fork worker
* processes, return NULL at exit;
* On error throw exception.
*
Expand All @@ -1088,27 +1088,28 @@ static rem_port* listener_socket(rem_port* port, USHORT flag, const addrinfo* pa
if (n == -1)
gds__log("setsockopt: error setting IPV6_V6ONLY to %d", ipv6_v6only);

#ifndef WIN_NT
// dimitr: on Windows, lack of SO_REUSEADDR works the same way as it was specified on POSIX,
// i.e. it allows binding to a port in a TIME_WAIT/FIN_WAIT state. If this option
// is turned on explicitly, then a port can be re-bound regardless of its state,
// e.g. while it's listening. This is surely not what we want.
// We set this options for any kind of listener, including standalone Classic.

int optval = TRUE;
n = setsockopt(port->port_handle, SOL_SOCKET, SO_REUSEADDR,
(SCHAR*) &optval, sizeof(optval));
if (n == -1)
{
inet_error(true, port, "setsockopt REUSE", isc_net_connect_listen_err, INET_ERRNO);
}
#endif

if (flag & SRVR_multi_client)
{
struct linger lingerInfo;
lingerInfo.l_onoff = 0;
lingerInfo.l_linger = 0;

#ifndef WIN_NT
// dimitr: on Windows, lack of SO_REUSEADDR works the same way as it was specified on POSIX,
// i.e. it allows binding to a port in a TIME_WAIT/FIN_WAIT state. If this option
// is turned on explicitly, then a port can be re-bound regardless of its state,
// e.g. while it's listening. This is surely not what we want.

int optval = TRUE;
n = setsockopt(port->port_handle, SOL_SOCKET, SO_REUSEADDR,
(SCHAR*) &optval, sizeof(optval));
if (n == -1)
{
inet_error(true, port, "setsockopt REUSE", isc_net_connect_listen_err, INET_ERRNO);
}
#endif

// Get any values for SO_LINGER so that they can be reset during
// disconnect. SO_LINGER should be set by default on the socket

Expand Down
Loading