Add missing synchronization to cached vectors of known pages #8069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvlad
approved these changes
Apr 4, 2024
hvlad
added a commit
that referenced
this pull request
May 27, 2024
Note, sequence numbers could be out of physical order of records.
hvlad
pushed a commit
that referenced
this pull request
Aug 27, 2024
hvlad
pushed a commit
that referenced
this pull request
Aug 27, 2024
dyemanov
added a commit
that referenced
this pull request
Nov 16, 2024
* Add missing synchronization to cached vectors of known pages. Thanks to Vlad Khorsun. * Fixed typo
dyemanov
pushed a commit
that referenced
this pull request
Nov 16, 2024
Note, sequence numbers could be out of physical order of records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes races (causing crashes) when vectors are accessed / reallocated under high concurrent load.
The original patch is implemented by Vlad Khorsun. Slightly optimized and stress-tested by myself.