Wrong database location resolution when DatabaseAccess restriced to specified directories [CORE4691]

[firebird-automations]

Submitted by: @pcisar

gstat (without user/pwd parameters, just -h header scan) doesn't open database in CWD when db filename is specified without full path and filename is located in directory listed in DatabaseAccess spec.

Example:

srv:/ssd #⁠ /opt/firebird/bin/gstat -h mydb.fdb
Database "/sata/mydb.fdb"

when specifying path it opens correct file:
srv:/ssd #⁠ /opt/firebird/bin/gstat -h /ssd/mydb.fdb
Database "/ssd/mydb.fdb"

DatabaseAccess = Restrict /data/db;/data/db2;/sata;/ssd;/ramfs

gstat tries to resolve the given filename via aliases.conf in order to support aliases. In 2.5 it was intended that ResolveDatabaseAlias() routine was modified to transform relative paths via DatabaseAccess. But it should have been done only for the engine, not for utilities that also use ResolveDatabaseAlias()

[firebird-automations]

Commented by: @dyemanov

Looking at the code, NBACKUP should be also affected.

[firebird-automations]

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

[firebird-automations]

Commented by: @AlexPeshkoff

Pavel, can you reproduce it in trunk?

[firebird-automations]

Commented by: @pcisar

Yes, I can reproduce with 2.5.4.26840 snapshot (19th Feb).

[firebird-automations]

Commented by: @AlexPeshkoff

But what about FB3, i.e. trunk?

[firebird-automations]

Commented by: @AlexPeshkoff

Pavel, I can add a check for presence of mydb.fdb in current directory. This will fix a case you mention here. But imagine a case when one does the following:

srv:/ssd #⁠ gbak -c copy.fbk restored.fdb

Where should be created restored.fdb? In /data/db or in /ssd? I'm afraid there is no good answer.