Skip to content

Adds support for Unicode characters in database filenames. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

fdcastel
Copy link
Member

Fix #11.

@fdcastel fdcastel force-pushed the fix-issue-11 branch 2 times, most recently from 8cf8c63 to ce2b75c Compare May 28, 2025 04:03
@fdcastel
Copy link
Member Author

I removed the Unicode character from the filename to rule out any issues related to the GitHub environment's filesystem.

However, the error still persists.

I'll leave it removed for now and will revert it once the failing tests in the GitHub test environment are resolved.

@fdcastel
Copy link
Member Author

I believe the issue is resolved, but the GitHub test environment still needs some adjustments.

On my build system, the new test passes:

# Invoke-Build FIREBIRD_DATABASE_can_create_database_with_unicode_characters ./image.tests.ps1

Build FIREBIRD_DATABASE_can_create_database_with_unicode_characters /opt/firebird-docker-fork/generated/4.0.5/bookworm/image.tests.ps1
Task /FIREBIRD_DATABASE_can_create_database_with_unicode_characters
Creating database '/tmp/próf-áêïôù.fdb'
Done /FIREBIRD_DATABASE_can_create_database_with_unicode_characters 00:00:05.8360229
Build succeeded. 1 tasks, 0 errors, 0 warnings 00:00:05.8389788

However, if I remove these two lines from the Dockerfile:

ENV LANG=C.UTF-8
ENV LC_ALL=C.UTF-8

The test fails.

- Adds environment variables for locale settings in Dockerfiles.
- Update database filename test for Unicode compatibility.
- Fix `realpath` call for paths with spaces.
- Adds test for databases with spaces in the path.
- Improves error message in tests if `FULL_IMAGE_NAME` env var is not set.

- Minor fix for `ExitCodeIs`.
@fdcastel fdcastel self-assigned this Jun 2, 2025
@fdcastel
Copy link
Member Author

fdcastel commented Jun 2, 2025

✅ All set! All images are passing.

Solved the original issue with Unicode characters, as well as another one related to paths containing spaces.

Adds support for Unicode characters in database filenames.

  • Adds environment variables for locale settings in Dockerfiles.
  • Update database filename test for Unicode compatibility.
  • Fix realpath call for paths with spaces.
  • Adds test for databases with spaces in the path.
  • Improves error message in tests if FULL_IMAGE_NAME env var is not set.
  • Minor fix for ExitCodeIs.

@fdcastel fdcastel merged commit d23a2cf into FirebirdSQL:master Jun 3, 2025
1 check passed
@fdcastel fdcastel deleted the fix-issue-11 branch June 3, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot transliterate character between character sets
2 participants