Skip to content

Conversation

justjish
Copy link
Contributor

Description

  1. Reordered error checking for SdkProvider so that it will actually throw error for no sdk provided.
  2. Resolve @ts-ignore in SdkProvider: v9 exposes props.sdk.app.name for all SDKs, so used that for app name comparison.
  3. For the remaining ts-ignores, replaced with @ts-expect-error.

Code sample

@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@jhuleatt
Copy link
Collaborator

jhuleatt commented Aug 29, 2021

Thanks for this cleanup @sujishpatel! Can you please run yarn docs from the root of the project to make that last check go green?

(Sorry that wasn't clear. I've updated the contributing guide to make it easier for future contributors).

@jhuleatt
Copy link
Collaborator

jhuleatt commented Sep 1, 2021

Thank you @sujishpatel!

@jhuleatt jhuleatt merged commit 24320c4 into FirebaseExtended:main Sep 1, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants