Skip to content

Conversation

justjish
Copy link
Contributor

Description

Code Cleanup: remote-config

  1. Use rxfire/remote-config for remote config getters. The getValue.tsx is simply a copy from rxfire/remote-config anyway.
  2. Use the public api for getting the app name for remote config rather than a private variable.
  3. Remove @param remoteConfig Optional instance. If not provided ReactFire will either grab the default instance or lazy load. from all comments.

Code sample

N/A - Functionality remains same.

@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@jhuleatt
Copy link
Collaborator

jhuleatt commented Sep 1, 2021

Thank you @sujishpatel!

@jhuleatt jhuleatt merged commit 857dbcd into FirebaseExtended:main Sep 1, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants