Skip to content

Conversation

@justjish
Copy link
Contributor

@justjish justjish commented Aug 1, 2021

Description

Updated to support firebase 9.0.0-beta.8.
Updated/Fixed tests, which were failing due to new method for connecting to emulators.

Code sample

@justjish justjish changed the base branch from main to modular-firebase August 1, 2021 05:09
@google-cla
Copy link

google-cla bot commented Aug 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 1, 2021
@jhuleatt
Copy link
Collaborator

jhuleatt commented Aug 2, 2021

Thank you @sujishpatel, this is a huge help! If you're able to sign the CLA, we can run the tests and then get this merged.

@justjish
Copy link
Contributor Author

justjish commented Aug 3, 2021

Odd. CLA is signed on my end. The error points to something.

@jhuleatt jhuleatt added cla: yes and removed cla: no labels Aug 3, 2021
@jhuleatt
Copy link
Collaborator

jhuleatt commented Aug 3, 2021

Double checked the CLA report and it looks good to me. Merging.

@jhuleatt jhuleatt merged commit c8a52d6 into FirebaseExtended:modular-firebase Aug 3, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants